Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 6.5.2 #38

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Update to 6.5.2 #38

merged 2 commits into from
Oct 28, 2024

Conversation

bethanyhgardner
Copy link
Contributor

I needed the Upwork and Bluesky icons that were added in v6.5, so I modified the asset files in my project's installation of the extension, modeling it after the changes in #32. Here it is, in case anyone else needs it! It works for my website, adding both new icons and icons that have existed in previous versions, but I'm not sure if there's a conventional way to test the full set of icons and the various ways to insert them.

@cscheid
Copy link
Contributor

cscheid commented Apr 22, 2024

Thanks, @bethanyhgardner, this looks great.

A few questions:

  • For larger PRs like this, we need you to file a contributor agreement with Posit. Can you follow the instructions on /~https://github.com/quarto-dev/quarto-cli/blob/main/CONTRIBUTING.md (specifically bullet point 2) and confirm on a reply here that you've done so?

  • Is the .css file a copy of the new font-awesome release? The only reason I ask is that some of the font names changed from "free" back to the other files that we're still shipping, but haven't changed. I worry a little that we're doing the wrong thing here. We'd love to merge this, but I just want to understand a bit better what's happening in those declarations.

@bethanyhgardner
Copy link
Contributor Author

Hi,

Ahh, sorry for my delayed response! I just submitted the contributor agreement.

I downloaded the free web version of fontawesome 6.5.2 and cross-referenced the files there with the ones included in this extension (the .ttf and .woff2 files in webfonts/ and all.css in css/). Looking at the font awesome release notes, I'm not sure if the update makes changes to file naming structure that would affect this extension, beyond just adding additional icons.

@cscheid cscheid requested a review from cderv May 6, 2024 15:17
@lnnrtwttkhn
Copy link

Would be lovely to have this merged! Thanks @bethanyhgardner for the PR!

@robjhyndman
Copy link

robjhyndman commented Oct 26, 2024 •
edited
Loading

What's holding this PR up? It would be great to have fontawesome updated to the latest version. (I know I can just install the version from @bethanyhgardner.)

cderv
cderv approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this one.

I downloaded the free web version of fontawesome 6.5.2 and cross-referenced the files there with the ones included in this extension (the .ttf and .woff2 files in webfonts/ and all.css in css/).

I think this is the right way to do it. The change we see is because the previous update 6.4.2 was not exactly using the all.css for the 6.4.2 free download of fontawesome release.

This PR makes things cleaner for future update regarding this extension providing equivalent of Free release of fontawesome at /~https://github.com/FortAwesome/Font-Awesome/releases

the other files that we're still shipping, but haven't changed.

I think we need to remove those.

@cderv cderv merged commit bc1062f into quarto-ext:main Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bethanyhgardner @cscheid @lnnrtwttkhn @robjhyndman @cderv